Skip to content

meta: add collaborator & contributing guides #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024

Conversation

flakey5
Copy link
Member

@flakey5 flakey5 commented Apr 2, 2024

No description provided.

@flakey5 flakey5 requested a review from a team as a code owner April 2, 2024 17:52
@flakey5 flakey5 marked this pull request as draft April 2, 2024 17:53
@ovflowd
Copy link
Member

ovflowd commented May 13, 2024

@flakey5 any update here? 👀

@flakey5 flakey5 force-pushed the flakey5/20240402/contributor-guides branch 3 times, most recently from d6d457d to 50d3d42 Compare May 15, 2024 06:47
@flakey5 flakey5 marked this pull request as ready for review May 15, 2024 06:48
@flakey5 flakey5 force-pushed the flakey5/20240402/contributor-guides branch from 50d3d42 to f4a25e9 Compare May 15, 2024 06:55
@flakey5 flakey5 force-pushed the flakey5/20240402/contributor-guides branch from f4a25e9 to 52602fd Compare May 25, 2024 17:42
@flakey5
Copy link
Member Author

flakey5 commented May 25, 2024

Added a readme update to the pr

@flakey5 flakey5 force-pushed the flakey5/20240402/contributor-guides branch from 52602fd to ae38cf9 Compare May 25, 2024 17:50
@flakey5 flakey5 force-pushed the flakey5/20240402/contributor-guides branch from ae38cf9 to 894322b Compare May 25, 2024 17:52
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good stuff :)

- A local version of the Worker is ran with Miniflare.
- Like Unit Tests, any external services should be mocked for these tests as well.

## Remarks on Structure and Background
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd maybe add a bit more of details on maybe specifics, but this can be iterate over time

@flakey5 flakey5 merged commit 6ad9e97 into main May 29, 2024
3 checks passed
@flakey5 flakey5 deleted the flakey5/20240402/contributor-guides branch May 29, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants