-
-
Notifications
You must be signed in to change notification settings - Fork 41
Completion fixes #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Completion fixes #698
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ using namespace lspserver; | |
|
||
namespace { | ||
|
||
constexpr int MaxItems = 30; | ||
constexpr int MaxItems = 1000; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the motivation or necessity behind this? |
||
|
||
void fillString(nix::EvalState &State, nix::Value &V, | ||
const std::vector<std::string_view> &AttrPath, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,7 +52,15 @@ | |
CHECK-NEXT: "jsonrpc": "2.0", | ||
CHECK-NEXT: "result": { | ||
CHECK-NEXT: "isIncomplete": false, | ||
CHECK-NEXT: "items": [] | ||
CHECK-NEXT: "items": [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the previous version gave more accurate results because the current "completion" feature is essentially providing completions within the "comments," which might confuse users. |
||
CHECK-NEXT: { | ||
CHECK-NEXT: "data": "", | ||
CHECK-NEXT: "detail": "nixos", | ||
CHECK-NEXT: "kind": 7, | ||
CHECK-NEXT: "label": "foo", | ||
CHECK-NEXT: "score": 0 | ||
CHECK-NEXT: } | ||
CHECK-NEXT: ] | ||
CHECK-NEXT: } | ||
``` | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line of code previously protected us from providing code completions within "comments."