Completion fixes #698
Open
Completion fixes #698
+25
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display all available completion options within the current attrset even if it's empty or there is no text under the cursor.
oandrew
force-pushed
the
completion-fixes
branch
from
c34567c to
4cd9d17
Compare
inclyc
reviewed
Jun 25, 2025
There was a problem hiding this comment.
Overall, I think:
- The current approach also provides completion suggestions within comment content, which I believe is undesirable.
- We should develop a parser that preserves the position of comments, so that we can check whether the location of the "completion" is inside a comment when performing it.
| @@ -52,7 +52,15 @@ | |||
| CHECK-NEXT: "jsonrpc": "2.0", | |||
| CHECK-NEXT: "result": { | |||
| CHECK-NEXT: "isIncomplete": false, | |||
| CHECK-NEXT: "items": [] | |||
| CHECK-NEXT: "items": [ | |||
There was a problem hiding this comment.
I think the previous version gave more accurate results because the current "completion" feature is essentially providing completions within the "comments," which might confuse users.
| @@ -14,7 +14,7 @@ using namespace lspserver; | |||
|
|
|||
| namespace { | |||
|
|
|||
| constexpr int MaxItems = 30; | |||
| constexpr int MaxItems = 1000; | |||
There was a problem hiding this comment.
What is the motivation or necessity behind this?
| const auto *Desc = AST->descend({Pos, Pos}); | ||
| CheckDefault(Desc && Desc->children().empty()); | ||
| CheckDefault(Desc); |
There was a problem hiding this comment.
This line of code previously protected us from providing code completions within "comments."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #653
networking.netwill also suggestuseNetworkd.quick video:
nixd.mov