Add ni-apis as a submodule #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeprosserni
requested review from
bkeryan,
maxxboehme and
zhindes
as code owners
bkeryan
requested changes
Oct 20, 2025
bkeryan
requested changes
Oct 21, 2025
bkeryan
approved these changes
Oct 21, 2025
mikeprosserni
deleted the
users/mprosser/task-3439518-ni-apis-submodule
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
This adds https://github.com/ni/ni-apis as a submodule of nidaqmx-python. (similar to ni/grpc-device#1201)
This allows us to access the canonical versions of proto files like session.proto. I'll also be wanting to access waveform.proto in the future, which is the main reason I'm doing this PR.
Why should this Pull Request be merged?
AB#3439518
What testing has been done?
CI Checks Passed