Skip to content

Conversation

mikeprosserni
Copy link
Contributor

@mikeprosserni mikeprosserni commented Oct 23, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

This updates the documentation in CONTRIBUTING.md to account for the new submodule. Developers must now clone the submodule as well as the repo itself. I also made a few other updates to the documented commands.

Also, after running the codegen command, I noticed that some __init__.py files were being created in empty directories. I've updated stub_generator.py to fix that.

Why should this Pull Request be merged?

image

What testing has been done?

I ran the commands listed in CONTRIBUTING.md.

@mikeprosserni mikeprosserni marked this pull request as ready for review October 23, 2025 14:26
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

Test Results

    48 files  ±0      48 suites  ±0   1h 13m 33s ⏱️ +5s
 3 098 tests ±0   2 439 ✅ ±0     659 💤 ±0  0 ❌ ±0 
60 008 runs  ±0  47 730 ✅ ±0  12 278 💤 ±0  0 ❌ ±0 

Results for commit eb7722b. ± Comparison against base commit eab34d2.

♻️ This comment has been updated with latest results.

…create them only if the directory contains Python files.
@mikeprosserni mikeprosserni merged commit ed59b48 into master Oct 23, 2025
31 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/submodule-followup branch October 23, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants