Skip to content

Adding new smoke tests to theme #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 55 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
1a4e351
Mainframe: Remove old css
nginx-jack Jun 9, 2025
2a7f080
Mainframe: Remove old js
nginx-jack Jun 9, 2025
4be5ef6
Mainframe: Removed css data-mf tags
lamATnginx Jun 9, 2025
d6d80ca
Mainframe: Disabled the visual regression test
lamATnginx Jun 9, 2025
57c9841
Mainframe: Add aria label to sidebar mobile button
lamATnginx Jun 9, 2025
b2de7d5
Mainframe: Removed screenshots
lamATnginx Jun 10, 2025
8e00c3e
Mainframe: Fix duplicate doc. Fix catalog
nginx-jack Jun 10, 2025
453e5bb
Mainframe: Fixed issue with card
lamATnginx Jun 10, 2025
6264fd1
Mainframe: Removed bootstrap, jquery css and js
lamATnginx Jun 12, 2025
9139655
Mainframe: Removed legacy coveo js
lamATnginx Jun 12, 2025
42dca5b
Mainframe: Fixed tab groups
lamATnginx Jun 16, 2025
de990b3
Mainframe: Added accessibility to tabs
lamATnginx Jun 16, 2025
21bfa13
Mainframe: Fixed header
lamATnginx Jun 16, 2025
a218e11
Mainframe: Adjusted js for tabs to add home + end + space support
lamATnginx Jun 17, 2025
5eebec8
Chore: Merge branch 'main' into mainframe
TasoOneAsia Jun 17, 2025
8c23ad0
Mainframe: Fixed F5 sites dropdown
lamATnginx Jun 17, 2025
3f08fa5
Grid: Restructure high-level DOM and Grid
nginx-jack Jun 20, 2025
4200a46
Redocly: Fix regrid layout
nginx-jack Jun 20, 2025
941527e
Sidebar: Add image and fix scroll behaviour
nginx-jack Jun 20, 2025
fb60399
Grid: Add spcing to header and content container
nginx-jack Jun 20, 2025
696e9c0
Homepage: Fix spacing, footer, and header
nginx-jack Jun 23, 2025
79a71ed
Layouts: Move shared layout components to base of
nginx-jack Jun 23, 2025
d53d624
Header: Fix search and f5 sites
nginx-jack Jun 23, 2025
e9b2699
Search: Fix search page render on new grid
nginx-jack Jun 24, 2025
23ec93b
Headers: Handle show hide logo depending on page
nginx-jack Jun 24, 2025
03b9f07
Headers: Add back product selector
nginx-jack Jun 24, 2025
e3f9270
Headers: Fix header responsivness
nginx-jack Jun 24, 2025
3ffd1d2
Card: Fixed build error on card-layout due to Scratch
lamATnginx Jun 24, 2025
84fa71d
Chore: Merge branch 'main' into mainframe
lamATnginx Jun 24, 2025
44c87a7
Mainframe: Removed old sidebar partial reference
lamATnginx Jun 24, 2025
52ca5c8
Mainframe: Update test product landing + small card bug fix
lamATnginx Jun 24, 2025
e7a086c
Chore: Merge branch 'mainframe' into mainframe-regrid
lamATnginx Jun 24, 2025
417422e
Landing: Updated list page with custom landing params
lamATnginx Jun 24, 2025
44a5a3d
Header: Added default product selector text
lamATnginx Jun 24, 2025
a8a39b3
Merge pull request #281 from nginxinc/mainframe-regrid
nginx-jack Jun 25, 2025
75b847a
Chore: Merge branch 'main' into mainframe
lamATnginx Jun 25, 2025
cbbb369
Fix: Truthy .Value check
TasoOneAsia Jun 25, 2025
46c6955
Chore: Merge branch 'main' into mainframe
lamATnginx Jun 25, 2025
a0e1c02
Biome: Update v2 and remove unused css files
nginx-jack Jun 27, 2025
13f83bd
Purgecss: Remove unused css from purgecss run
nginx-jack Jun 27, 2025
f6a77b9
Merge pull request #289 from nginxinc/biome-v2
nginx-jack Jun 27, 2025
9fc3a63
Chore: Merge branch 'main' into mainframe
lamATnginx Jun 27, 2025
b180269
Feat: Mainframe tables + deprecate bootstrap-table
TasoOneAsia Jun 27, 2025
ba8de8b
Mainframe: Fix up old 404 page
TasoOneAsia Jun 27, 2025
bb0c31a
Merge pull request #293 from nginxinc/misc/mainframe-fixes
nginx-jack Jul 1, 2025
fefd62f
Headers: Add border to breadcrumb for mobile
nginx-jack Jun 30, 2025
c852b71
Headers: Set spacing to around
nginx-jack Jun 30, 2025
4e1a2f1
Sidebar: Add initial collapsible sidebar
nginx-jack Jun 30, 2025
11e93fa
Header: Sticky and add blur effect
nginx-jack Jun 30, 2025
a33f8ce
Header: Add f5 logo instead of sites button
nginx-jack Jul 1, 2025
8b8a3ee
Header: Fix coveo search breaking page height
nginx-jack Jul 1, 2025
cec8411
Tests: Added new UI smoke tests
lamATnginx Jul 1, 2025
8ab2810
Tests: Added test for header
lamATnginx Jul 1, 2025
16f11cb
Tests: Fixed issue with product landing test
lamATnginx Jul 1, 2025
0dee3ac
Tests: Update GH workflows
lamATnginx Jul 1, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Testing for visual regression on old theme
name: Running Playwright test on UI

# Run the workflow when code is pushed or when a pull request is created
on:
Expand All @@ -25,19 +25,16 @@ jobs:
- name: Install dependencies and playwright browsers
run: cd tests && npm ci && npx playwright install --with-deps
- name: Run Playwright tests
id: test-visual
id: test-ui
run: |
make tests | tee output.log
if grep -q -e "Error: A snapshot doesn't exist at" -e "Screenshot comparison failed" output.log; then
echo "Playwright tests failed due to a snapshot issue."
exit 1
elif grep -q "failed" output.log; then
echo "Playwright tests failed due to a non-snapshot issue."
if grep -q "failed" output.log; then
echo "Playwright tests failed. Please view the Playwright report to see full error."
exit 1
fi
- uses: actions/upload-artifact@v4
id: artifact-upload
if: ${{ !cancelled() && failure() && steps.test-visual.conclusion == 'failure' }}
if: ${{ !cancelled() && failure() && steps.test-ui.conclusion == 'failure' }}
with:
name: playwright-report
path: tests/playwright-report/
Expand All @@ -47,10 +44,9 @@ jobs:
if: ${{ failure() }}
with:
script: |
const body = `### <span aria-hidden="true">❌</span> Playwright visual snapshot differences were detected.
const body = `### <span aria-hidden="true">❌</span> Playwright differences were detected.

View the [Playwright report](${{ steps.artifact-upload.outputs.artifact-url }})
**To approve the snapshot changes and update the snapshots, please comment:** /approve-snapshots`;
View the [Playwright report](${{ steps.artifact-upload.outputs.artifact-url }})`;

await github.rest.issues.createComment({
issue_number: context.issue.number,
Expand Down
58 changes: 0 additions & 58 deletions .github/workflows/update-screenshot.yml

This file was deleted.

2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
BIOME_BASE_CMD := $(if $(shell which biome),biome,npx @biomejs/biome@1.9.4)
BIOME_BASE_CMD := $(if $(shell which biome),biome,npx @biomejs/biome@2.0.6)
BIOME_CONFIG_PATH := --config-path="biome.json"
WRITE_FLAG := --write

Expand Down
6 changes: 0 additions & 6 deletions assets/css/all.min.css

This file was deleted.

Loading
Loading