Skip to content

Adding new smoke tests to theme #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 55 commits into from
Closed

Adding new smoke tests to theme #295

wants to merge 55 commits into from

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Adding basic tests.

TODO: create a new epic and tickets on what to add. This PR is just for smoke tests ti ensure the dom renders fine and doesn't have a 404 error.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

nginx-jack and others added 30 commits June 9, 2025 14:37
Simplifies overall high level DOM structure and uses new grid system.
This is still work-in-progress. Sidebar, header and redocly page still
require refactoring to look as expected.
@lamATnginx lamATnginx self-assigned this Jul 1, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner July 1, 2025 23:21
@lamATnginx lamATnginx added the enhancement New feature or request label Jul 1, 2025
@lamATnginx lamATnginx marked this pull request as draft July 1, 2025 23:21
Copy link

github-actions bot commented Jul 1, 2025

❌ One or more of the commit messages in this PR do not match the nginx-hugo-theme git guidelines, please check the CI job for more details on which commits were flagged and why.

Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

Copy link

github-actions bot commented Jul 1, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/295/

Copy link

github-actions bot commented Jul 1, 2025

Playwright visual snapshot differences were detected.

View the Playwright report
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

This comment was marked as spam.

This comment was marked as spam.

@lamATnginx lamATnginx closed this Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants