Skip to content

Command line code generator for supporting files #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Command line code generator for supporting files #101

merged 1 commit into from
Jul 10, 2024

Conversation

dengsh12
Copy link
Contributor

@dengsh12 dengsh12 commented Jul 3, 2024

Proposed changes

In the past, when people want to add support for new dynamic modules, or update current existing directive definitions in nginx-go-crossplane, they always need to look at documents or source codes and find the definition of directives.

In this PR, we provide a command line tool, which can read from a directory containing source codes, and generate the corresponding supporting file. The supporting file will include a map from directives to their bitmask definitions, and a public MatchFunc to match them. It will be in the same format of currently existing supporting files like analyze_otel_directives.go, analyze_oss_latest_directives.go.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@dengsh12 dengsh12 requested a review from a team as a code owner July 3, 2024 16:56
@dengsh12 dengsh12 merged commit e00ed70 into nginxinc:main Jul 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants