-
Notifications
You must be signed in to change notification settings - Fork 16
Command line code generator for supporting files #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornj
reviewed
Jul 3, 2024
ornj
reviewed
Jul 3, 2024
ornj
reviewed
Jul 3, 2024
ornj
reviewed
Jul 3, 2024
ornj
reviewed
Jul 3, 2024
ornj
reviewed
Jul 3, 2024
ornj
reviewed
Jul 3, 2024
ornj
reviewed
Jul 3, 2024
ornj
reviewed
Jul 3, 2024
ornj
reviewed
Jul 8, 2024
ornj
reviewed
Jul 8, 2024
ornj
approved these changes
Jul 9, 2024
valyria257
reviewed
Jul 9, 2024
valyria257
reviewed
Jul 9, 2024
valyria257
approved these changes
Jul 9, 2024
nginx-nickc
reviewed
Jul 10, 2024
This was referenced Jul 10, 2024
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In the past, when people want to add support for new dynamic modules, or update current existing directive definitions in nginx-go-crossplane, they always need to look at documents or source codes and find the definition of directives.
In this PR, we provide a command line tool, which can read from a directory containing source codes, and generate the corresponding supporting file. The supporting file will include a map from directives to their bitmask definitions, and a public
MatchFunc
to match them. It will be in the same format of currently existing supporting files likeanalyze_otel_directives.go
,analyze_oss_latest_directives.go
.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentREADME.md
)