-
Notifications
You must be signed in to change notification settings - Fork 16
go generate support for oss/public modules #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
- Coverage 78.82% 76.57% -2.26%
==========================================
Files 26 26
Lines 1124 1161 +37
==========================================
+ Hits 886 889 +3
- Misses 182 216 +34
Partials 56 56 ☔ View full report in Codecov by Sentry. |
4 tasks
ornj
requested changes
Jul 26, 2024
ornj
reviewed
Jul 29, 2024
ornj
reviewed
Jul 29, 2024
ornj
reviewed
Jul 29, 2024
ornj
reviewed
Jul 29, 2024
ornj
reviewed
Jul 30, 2024
ornj
reviewed
Jul 30, 2024
ornj
approved these changes
Jul 30, 2024
valyria257
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
We plan to provide a tool to update supporting files(
analyze_*_directives.go
) bygo generate
. This MR is to providego generate
update for oss and public modules(oss/lua/otel//njs/headersmore).go generate
only targets for dynamic modules(or OSS, NPlus) we want to provide long-lasting supports for. To provide temporary support for a module, please refer to #101Here are the detailed changes:
./scripts/public_source_gen.sh
) to fetch code from github and generate corresponding support files. It would make adding new dynamic modules or updating current existing support files easy..gen.go
suffix to generated files and ignore them ingolangci-lint
go:generate
comments for oss and public modules inanalyze.go
./cmd/generate
can read from json file nowMatchFunc
and directives map in.gen.go
files.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentREADME.md
)