Skip to content

Add fasta to picard/collectalignmentsummarymetrics #8392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

randombenj
Copy link
Contributor

@randombenj randombenj commented May 5, 2025

PR checklist

With this change one can add a fasta reference genome for alignment metrics summary:
https://gatk.broadinstitute.org/hc/en-us/articles/13832683660955-CollectAlignmentSummaryMetrics-Picard#--REFERENCE_SEQUENCE

Unfortunately this will be a breaking change as I couldn't find a way to add optional input parameters.

Tagging @mikefeixu as the original author of #8287

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we give the fasta channel a meta map, as is generally done for most modules (at least when they are updated). This helps with metagenomics pipelines where there may be more than one fasta file.

@randombenj randombenj requested a review from SPPearce May 12, 2025 06:39
@SPPearce
Copy link
Contributor

If you message on the github-invitations channel on the nf-core slack the workflows will run for you.

@SPPearce SPPearce enabled auto-merge May 12, 2025 15:17
@SPPearce SPPearce added this pull request to the merge queue May 13, 2025
Merged via the queue into nf-core:master with commit 1a23c0b May 13, 2025
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants