Skip to content

Use ECS properties instead of container properties #6270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jorgee
Copy link
Contributor

@jorgee jorgee commented Jul 11, 2025

Closes #5096

Ports the @tom-seqera implementation in #5391 to AWS SDK v2 implementation.

With the RegisterJobDefinitionModel and ContainerPropertiesModel introduced by @pditommaso, these changes shouldn't affect the xpack as the interface it extends remains untouched.

Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Copy link

netlify bot commented Jul 11, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 08248ac
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/687e3ff6dbde6c000727cc79

@pditommaso
Copy link
Member

Nice, let's test using [e2e prod] in the commit message

@pditommaso
Copy link
Member

@jorgee aws tests are failing

@jorgee
Copy link
Contributor Author

jorgee commented Jul 21, 2025

It seems the tests are failing because of the job definition reuse. The old definition is using containerProperties and the new one is trying to override with ecsProperties. If I am not wrong, the job definition is reused if container name and nf-token is the same, isn't it? So, I think we should include something else to the token to ensure both are using the same container or ecs properties.

jorgee added 2 commits July 21, 2025 13:36
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
@jorgee
Copy link
Contributor Author

jorgee commented Jul 21, 2025

Token was basically hashing the result of containerProperties.toString. I have added a fake property ecsMode=true in the new version. If there is a job definition with same values but with the previous version, the token will be different and it will generate a new revision. Now, the job is failing because of CI user role permissions as in the other CI pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS: Switch from containerProperties to ecsProperties
3 participants