-
Notifications
You must be signed in to change notification settings - Fork 711
Resolve auth for Git providers that use tokens #6212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
It may be better to override it in the class that has support for it. I only see it supported by these nextflow/modules/nextflow/src/main/groovy/nextflow/scm/GiteaRepositoryProvider.groovy Lines 45 to 55 in b334df1
nextflow/modules/nextflow/src/main/groovy/nextflow/scm/GitlabRepositoryProvider.groovy Lines 42 to 51 in b334df1
|
The idea of adding it in the parent class is that more may come, such as #6209. |
I see. Yes, it would be better to handle at specific provider level |
Those Git providers that rely on tokens for authentication (GitLab, Gitea, Bitbucket) do not need username and password to be defined too.
This PR tweaks the logic that determines whether a Git provider has authentication properties configured or not to take into account the sole presence of the
token
field.