-
Notifications
You must be signed in to change notification settings - Fork 709
Add version, kind, and spec to lineage schema #6075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
modules/nf-lineage/src/main/nextflow/lineage/serde/LinTypeAdapterFactory.groovy
Outdated
Show resolved
Hide resolved
This looks nice, likely we needed to update the version to |
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Jorge Ejarque <jorgee@users.noreply.github.com>
For these PR, as there aren't changes in the model I think there is no need to update the version. I can make able to read both with |
It might be enough to simply ignore records that have an incompatible version and warn about them so that the user is aware. At least while the version is in beta. Maybe in the future we could add backwards compatibility, e.g. v1 / v2 data models, but hopefully we can iron out any changes in the beta period |
b4b321e
to
069653d
Compare
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
I've added the backward compatibility with the previous lineage format and test. Please review and merge if OK. Claude prompt for the posterity:
|
modules/nf-commons/src/main/nextflow/serde/gson/RuntimeTypeAdapterFactory.java
Outdated
Show resolved
Hide resolved
…pterFactory.java [ci skip] Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Changes are fine with me. |
This PR refactors the Lineage data encoder to serialize lineage records using the following structure:
For instance a
FileOutput
type is serialized as: