Skip to content

Refactor lineage annotations as list #6022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 2, 2025
Merged

Refactor lineage annotations as list #6022

merged 8 commits into from
May 2, 2025

Conversation

jorgee
Copy link
Contributor

@jorgee jorgee commented Apr 30, 2025 •
edited
Loading

This PR solves the discussion in #6014 (comment)

  • Changes annotations field from Map to List
  • Rename annotations to labels
  • process.label to TaskRun labels
  • Allow to search with several labels labels=label1&labels=label2
  • Allow labels including '='. In search argument, first '=' will be used as separator others are part of the value"

@jorgee
Change lineage annotations from map to list
61b3395 
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
@netlify Netlify
Copy link

netlify bot commented Apr 30, 2025 •
edited
Loading

✅ Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 03002f4
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/6814c9b65b14310008a15530

@jorgee jorgee mentioned this pull request Apr 30, 2025
Merged
1 task
@jorgee
pushing missing files
6d705f6 
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
@bentsherman bentsherman self-requested a review April 30, 2025 14:24
@jorgee
fix test
a91e912 
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
@bentsherman bentsherman changed the title Refactor lineage annotations Refactor lineage annotations as list May 1, 2025
@jorgee
rename annotations to labels, support duplicated key in queryparams t…
7293248 
…o support several labels search, add labels at index file

Signed-off-by: jorgee <jorge.ejarque@seqera.io>
@jorgee jorgee marked this pull request as ready for review May 2, 2025 10:13
@jorgee jorgee requested review from a team as code owners May 2, 2025 10:13
@jorgee jorgee requested a review from pditommaso May 2, 2025 10:13
pditommaso
pditommaso reviewed May 2, 2025
View reviewed changes
Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good. the only think not getting why moving from Map<String, String> params to Map<String, Object> params

jorgee and others added 2 commits May 2, 2025 12:50
@jorgee
Delete modules/nf-lineage/src/main/nextflow/lineage/LinObserver.groov…
e5a74b9 
…y.bk

Signed-off-by: Jorge Ejarque <jorgee@users.noreply.github.com>
@jorgee
change query params from object to list
95e863a 
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
bentsherman added 2 commits May 2, 2025 08:33
@bentsherman
cleanup
b0e3726 
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman
Merge branch 'master' into lineage-annotations
03002f4
@pditommaso pditommaso merged commit 9280b59 into master May 2, 2025
22 of 23 checks passed
@pditommaso pditommaso deleted the lineage-annotations branch May 2, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pditommaso pditommaso pditommaso approved these changes

@bentsherman bentsherman bentsherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgee @pditommaso @bentsherman