-
Notifications
You must be signed in to change notification settings - Fork 684
Update for VM sizes and regions required for Azure Batch #5985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Robbert Ijsselsteijn <r.ijsselsteijn@erasmusmc.nl>
…ted sizes Signed-off-by: Robbert Ijsselsteijn <r.ijsselsteijn@erasmusmc.nl>
Signed-off-by: Robbert Ijsselsteijn <r.ijsselsteijn@erasmusmc.nl>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
@adamrtalbot I'm fine with merging as long as the tests pass since it's a routine update, but if you could give a quick sanity check I would appreciate it |
It looks fine, but I really don't like having an additional powershell script in the repo. When we go to update it next time, do we use the bash or the powershell? Ideally we stick with bash to keep it simple although I notice Powershell can be installed on mac and linux now (not that I'm going to do it). sigh we need to automate this by adding it into the code, having all these JSON files is silly. |
Worth running e2e tests 👉 de05ecc |
An azure pipeline is hanging with 3 tasks never ending .. |
Is this on the platform? There was a platform upgrade last night so it's likely broken some running pipelines. |
Yes, the test was Platform |
Updated the regions and VM sizes for Azure batch as mentioned in issue: 3004533060.
Also a powershell script was added to obtain only the relevant regions, as the old bash script obtained all regions, even if they were not associated to a compute, causing the get VM size script to add additional unused JSONs.