Skip to content

Update for VM sizes and regions required for Azure Batch #5985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2025

Conversation

rijssel
Copy link
Contributor

@rijssel rijssel commented Apr 18, 2025

Updated the regions and VM sizes for Azure batch as mentioned in issue: 3004533060.

Also a powershell script was added to obtain only the relevant regions, as the old bash script obtained all regions, even if they were not associated to a compute, causing the get VM size script to add additional unused JSONs.

rijssel added 3 commits April 18, 2025 23:06
Signed-off-by: Robbert Ijsselsteijn <r.ijsselsteijn@erasmusmc.nl>
…ted sizes

Signed-off-by: Robbert Ijsselsteijn <r.ijsselsteijn@erasmusmc.nl>
Signed-off-by: Robbert Ijsselsteijn <r.ijsselsteijn@erasmusmc.nl>
Copy link

netlify bot commented Apr 18, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 919d301
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/68077cee614e1e00082d493c

@bentsherman
Copy link
Member

@adamrtalbot I'm fine with merging as long as the tests pass since it's a routine update, but if you could give a quick sanity check I would appreciate it

@adamrtalbot
Copy link
Collaborator

It looks fine, but I really don't like having an additional powershell script in the repo. When we go to update it next time, do we use the bash or the powershell? Ideally we stick with bash to keep it simple although I notice Powershell can be installed on mac and linux now (not that I'm going to do it).

sigh we need to automate this by adding it into the code, having all these JSON files is silly.

@bentsherman bentsherman merged commit 297150b into nextflow-io:master Apr 22, 2025
22 checks passed
@pditommaso
Copy link
Member

Worth running e2e tests 👉 de05ecc

@pditommaso
Copy link
Member

An azure pipeline is hanging with 3 tasks never ending ..

@adamrtalbot
Copy link
Collaborator

An azure pipeline is hanging with 3 tasks never ending ..

Is this on the platform? There was a platform upgrade last night so it's likely broken some running pipelines.

@pditommaso
Copy link
Member

Yes, the test was Platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants