-
Notifications
You must be signed in to change notification settings - Fork 108
Resolve issue with GitHub Actions runner running out of disk space #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
willtai
merged 7 commits into
neo4j:main
from
willtai:fix-out-of-space-error-on-gh-actions
Aug 6, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e4f3330
Reduce parallelism
willtai a0acb2a
Docker pruning
willtai b507b2c
Max parallel 3 jobs
willtai 4262300
Increase concurrent limit to 6
willtai fb4feca
New workflow for scheduled E2E tests on main
willtai bd49020
Update .github/workflows/scheduled-e2e-tests.yaml
willtai 7128e12
Removed push rules from pr-e2e-tests.yaml
willtai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
name: 'Neo4j-GenAI Scheduled E2E Tests' | ||
|
||
on: | ||
schedule: | ||
- cron: '0 6,9,12,15,18 * * 1-5' # Runs every 3 hours daytime on working days | ||
push: | ||
branches: | ||
- main | ||
|
||
jobs: | ||
e2e-tests: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
max-parallel: 6 | ||
matrix: | ||
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] | ||
neo4j-version: | ||
- 5 | ||
neo4j-edition: | ||
- community | ||
- enterprise | ||
services: | ||
t2v-transformers: | ||
image: cr.weaviate.io/semitechnologies/transformers-inference:sentence-transformers-all-MiniLM-L6-v2-onnx | ||
env: | ||
ENABLE_CUDA: '0' | ||
weaviate: | ||
image: cr.weaviate.io/semitechnologies/weaviate:1.25.1 | ||
env: | ||
TRANSFORMERS_INFERENCE_API: 'http://t2v-transformers:8080' | ||
AUTHENTICATION_ANONYMOUS_ACCESS_ENABLED: 'true' | ||
DEFAULT_VECTORIZER_MODULE: 'text2vec-transformers' | ||
ENABLE_MODULES: 'text2vec-transformers' | ||
CLUSTER_HOSTNAME: 'node1' | ||
ports: | ||
- 8080:8080 | ||
- 50051:50051 | ||
neo4j: | ||
image: neo4j:${{ matrix.neo4j-version }}-${{ matrix.neo4j-edition }} | ||
env: | ||
NEO4J_AUTH: neo4j/password | ||
NEO4J_ACCEPT_LICENSE_AGREEMENT: 'eval' | ||
NEO4J_PLUGINS: '["apoc"]' | ||
ports: | ||
- 7687:7687 | ||
- 7474:7474 | ||
|
||
steps: | ||
- name: Check out repository code | ||
uses: actions/checkout@v4 | ||
- name: Docker Prune | ||
run: | | ||
docker system prune -af | ||
docker volume prune -f | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install Poetry | ||
uses: snok/install-poetry@v1 | ||
with: | ||
virtualenvs-create: true | ||
virtualenvs-in-project: true | ||
installer-parallel: true | ||
- name: Set Python version for Poetry | ||
run: poetry env use python${{ matrix.python-version }} | ||
- name: Load cached venv | ||
id: cached-poetry-dependencies | ||
uses: actions/cache@v4 | ||
with: | ||
path: .venv | ||
key: ${{ runner.os }}-venv-${{ matrix.python-version }}-${{ hashFiles('**/poetry.lock') }} | ||
- name: Install dependencies | ||
if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true' | ||
run: poetry install --no-interaction --no-root | ||
- name: Install root project | ||
run: poetry install --no-interaction | ||
- name: Install dependencies | ||
run: poetry install --with dev | ||
- name: Wait for Weaviate to start | ||
shell: bash | ||
run: | | ||
set +e | ||
count=0; until curl -s --fail localhost:8080/v1/.well-known/ready; do ((count++)); [ $count -ge 10 ] && echo "Reached maximum retry limit" && exit 1; sleep 15; done | ||
- name: Run tests | ||
shell: bash | ||
run: | | ||
if [[ "${{ matrix.neo4j-edition }}" == "community" ]]; then | ||
poetry run pytest -m 'not enterprise_only' ./tests/e2e | ||
else | ||
poetry run pytest ./tests/e2e | ||
fi |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need a cron job? Can't we just run it every time there is a push to the main branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but it won't run if there hasn't been a push to main in a long time, which is why I have both. Is there a concern with doing this every 3 hours?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I'm confused, what are we testing if there is no change? The latest versions of the dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would we needed to run them again if there hasn't been a push to main in a while?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes especially external integrations such as Pinecone and Weaviate. Do you think this will be likely to change?
I don't see a downside to having this run periodically as the job will likely take about 10 minutes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see now, sounds good. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not fix the versions of those though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We fix the minimum version, it will install the latest version but not the next major version