Resolve issue with GitHub Actions runner running out of disk space #93
Conversation
willtai
force-pushed
the
fix-out-of-space-error-on-gh-actions
branch
from
13c5cbc to
a0acb2a
Compare
.github/workflows/pr-e2e-tests.yaml
Outdated
| push: | ||
| branches: | ||
| - main | ||
| - fix-out-of-space-error-on-gh-actions |
There was a problem hiding this comment.
I will remove this after the review. This is to test that this workflow works when I push to my working branch
Co-authored-by: Oskar Hane <oh@oskarhane.com>
|
|
||
| on: | ||
| schedule: | ||
| - cron: '0 6,9,12,15,18 * * 1-5' # Runs every 3 hours daytime on working days |
There was a problem hiding this comment.
Do we really need a cron job? Can't we just run it every time there is a push to the main branch?
There was a problem hiding this comment.
We could, but it won't run if there hasn't been a push to main in a long time, which is why I have both. Is there a concern with doing this every 3 hours?
There was a problem hiding this comment.
Sorry I'm confused, what are we testing if there is no change? The latest versions of the dependencies?
There was a problem hiding this comment.
Why would we needed to run them again if there hasn't been a push to main in a while?
There was a problem hiding this comment.
The latest versions of the dependencies
Yes especially external integrations such as Pinecone and Weaviate. Do you think this will be likely to change?
I don't see a downside to having this run periodically as the job will likely take about 10 minutes.
There was a problem hiding this comment.
Ok, I see now, sounds good. Thanks!
There was a problem hiding this comment.
Do we not fix the versions of those though?
There was a problem hiding this comment.
weaviate-client = "^4.6.1"
We fix the minimum version, it will install the latest version but not the next major version
…eo4j#93) * Reduce parallelism * Docker pruning * Max parallel 3 jobs * Increase concurrent limit to 6 * New workflow for scheduled E2E tests on main * Update .github/workflows/scheduled-e2e-tests.yaml Co-authored-by: Oskar Hane <oh@oskarhane.com> * Removed push rules from pr-e2e-tests.yaml --------- Co-authored-by: Oskar Hane <oh@oskarhane.com>
Description
Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):