Pipeline viz #122
Merged
Pipeline viz #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this dict when fetching the component inputs
…on to prepare for drawing pipelines (without user inputs)
…to feature/pipeline-viz # Conflicts: # docs/source/user_guide_pipeline.rst
15 tasks
willtai
reviewed
Sep 10, 2024
stellasia
commented
Sep 11, 2024
a-s-g93
pushed a commit
to a-s-g93/neo4j-genai-python-dev
that referenced
this pull request
Sep 13, 2024
* Save input configs in the Pipeline class while validating, and reuse this dict when fetching the component inputs * Split the parameter connection validation and the user input validation to prepare for drawing pipelines (without user inputs) * WIP: pipeline visualization * Invalidate the pipeline param mapping if the graph structure changes * Hide unused outputs by default but add option to display them * Install graphviz during CI * Install graphviz-dev in CI to fix installation error * Update changelog and doc * Add a few tests for data validation * Fix error message * This is a change of behavior that will be implemented in a separate PR * Add UT for pipeline to pygraphviz format and pipeline draw method * Fix docstring * Improve naming and docstrings * Update CHANGELOG.md
a-s-g93
pushed a commit
to a-s-g93/neo4j-genai-python-dev
that referenced
this pull request
Sep 13, 2024
* Save input configs in the Pipeline class while validating, and reuse this dict when fetching the component inputs * Split the parameter connection validation and the user input validation to prepare for drawing pipelines (without user inputs) * WIP: pipeline visualization * Invalidate the pipeline param mapping if the graph structure changes * Hide unused outputs by default but add option to display them * Install graphviz during CI * Install graphviz-dev in CI to fix installation error * Update changelog and doc * Add a few tests for data validation * Fix error message * This is a change of behavior that will be implemented in a separate PR * Add UT for pipeline to pygraphviz format and pipeline draw method * Fix docstring * Improve naming and docstrings * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for pipeline visualisation as image.
To make things easier and avoid to build (again) the parameter mapping dict when building the visualisation graph, a
parameter_mappingvariable is added to thePipelineclass. This variable is fed during the "connection validation". That means that the previousinput_config_validationis now split into two methods:validate_connection_parameters), ie the input config defined in theconnectmethod: this method checks that the component and parameter name actually exists. It feeds theparam_mappingdict and themissing_inputsdict (list of required parameters for components that are not mapped in anyconnectand that must be provided by user). Theparam_mappingdict is reused when building the component inputs during a run, and by the visualisation methods.validate_all_parameters): checks that the missing parameters are actually provided by users.Type of Change
Complexity
Complexity: Medium
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):