-
Notifications
You must be signed in to change notification settings - Fork 108
Raise error on wrong parameter mapping during pipeline definition #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this dict when fetching the component inputs
…on to prepare for drawing pipelines (without user inputs)
…to feature/pipeline-viz # Conflicts: # docs/source/user_guide_pipeline.rst
…into fix/errors-in-param-mapping
willtai
reviewed
Sep 16, 2024
willtai
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the pipeline definition check by raising an error before the pipeline run starts if:
"value" for component "b" can only be mapped to "a" or "b", not both.
"a" is not an valid input for "MyComponent".
In both cases,
PipelineDefinitionError
is raised.Also, introduce an
invalidate
method, so that the instance attributes are cleaned properly when invalidating the pipeline (if not, when adding a component after the pipeline has already been validated, the validation would fail because the parameter already exists in the param mapping dict from the previous validation).Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):