-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
TRAANode: New TRAA implementation. #31421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
@Mugen87 Why is there a vibration in the rendering now? I'm using pixel ratio 1, and it's quite noticeable. |
Maybe it's best to revert the #31361 PR for now. I have to check what happened, but opening it now I noticed that it's quite different. If this PR takes a long time... |
Sounds good! I'm not sure how long it takes to fix the instability issue. |
Okay, the vibration should be fixed now. The behavior is now as before. |
Thanks @Mugen87. I introduced |
It's definitely a step forward compared to my initial approach since |
Fixed #29842.
Description
The PR implements what has been suggested in #31361 (comment).
TRAAPassNode
is transformed toTRAANode
so it is not an alternative toPassNode
anymore. Now, you render a scene as always withpass()
node and the common MRT settings.traa()
is now added in the pass chain likeao()
,ssr()
orbloom()
which makes it much more practical to use.I've directly updated the AO demo to use TRAA instead of MSAA which brings the framerate back to 60 and also improves the overall AA quality.
@sunag I have not found yet an elegant way to integrate TRAA into
PostProcessing
. Right now, a separate callpostProcessing.setTRAANode( traaNode );
is required to tellPostProcessing
TRAA is in place. That is required so inrender()
the view offset (Jitter) can properly be configured. Is there a way to traverse the FX nodes so we can automatically detect an instance ofTRAANode
inPostProcessing
?