Skip to content

Revert "TSL: Add MRT support for traaPass()" #31424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 15, 2025

Reverts #31361

Reverting the PR due to some regression noticed in #31421.

@Mugen87 Mugen87 merged commit e3853ed into dev Jul 15, 2025
7 of 8 checks passed
@Mugen87 Mugen87 added this to the r179 milestone Jul 15, 2025
@Mugen87 Mugen87 deleted the revert-31361-dev-mrt-traa branch July 15, 2025 21:27
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.28
78.93
338.28
78.93
+0 B
+0 B
WebGPU 557.43
154.27
557.43
154.27
+0 B
+0 B
WebGPU Nodes 556.35
154.05
556.35
154.05
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 469.62
113.66
469.62
113.66
+0 B
+0 B
WebGPU 633.19
171.36
633.19
171.36
+0 B
+0 B
WebGPU Nodes 588.33
160.68
588.33
160.68
+0 B
+0 B

@sunag
Copy link
Collaborator

sunag commented Jul 15, 2025

@Mugen87 Could you just confirm, but I think it would be better to revert it again if the problem was related to this #31423

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 15, 2025

#31423 just fixed the color space issue.

The revert of #31361 fixed an issue that looked like a mismatched resolution to me.

It's best if you checkout a branch with the commit from #31361 and compare with prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants