-
Notifications
You must be signed in to change notification settings - Fork 626
Fix/controller yaml defaults #3478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This pull request is in conflict. Could you fix it @Eldgar? |
Please target the |
a354e8c
to
ecb1ba7
Compare
This pull request is in conflict. Could you fix it @Eldgar? |
ecb1ba7
to
d052d11
Compare
ce4ef51
to
6301607
Compare
6301607
to
a01de6b
Compare
I've triggered the CI - looks like the linter isn't happy with a bit of the whitespace |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3478 +/- ##
==========================================
+ Coverage 46.23% 46.23% +0.01%
==========================================
Files 720 720
Lines 62713 62738 +25
Branches 7591 7595 +4
==========================================
+ Hits 28991 29003 +12
- Misses 33555 33567 +12
- Partials 167 168 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fix
When the user skips “Edit Selected,” Setup Assistant dropped
action_ns
anddefault
frommoveit_controllers.yaml
(see #3434).This patch adds fallback values:
action_ns: follow_joint_trajectory
default: true
Test
Adds
InjectedDefaultsWhenBlank
totest_controllers.cpp
to verifythose keys are always present.
Fixes #3434