Skip to content

fix: treat tilde path as absolute [80] #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: treat tilde path as absolute [80] #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49ae30d
fix: [80] handle tilde path as absolute
patrik-simunic-cz Feb 19, 2025
3818f52
internal: bump vscode-extension patch version
patrik-simunic-cz Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vscode-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"version": "0.14.0",
"version": "0.14.1",
"name": "moon-console",
"publisher": "moonrepo",
"displayName": "moon console",
Expand Down
2 changes: 1 addition & 1 deletion packages/vscode-extension/src/workspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export class Workspace {
binPath += '.exe';
}

if (!path.isAbsolute(binPath)) {
if (!path.isAbsolute(binPath) && !binPath.startsWith('~')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for this block, but I don't think it will work for the for lookup below.

Maybe do an "if starts with ~, replace with home dir" approach.

binPath = path.join(this.root, binPath);
}

Expand Down
Loading