fix: treat tilde path as absolute [80] #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrik-simunic-cz
changed the title
patrik-simunic-cz
changed the title
milesj
reviewed
Feb 19, 2025
| @@ -168,7 +168,7 @@ export class Workspace { | |||
| binPath += '.exe'; | |||
| } | |||
|
|
|||
| if (!path.isAbsolute(binPath)) { | |||
| if (!path.isAbsolute(binPath) && !binPath.startsWith('~')) { | |||
There was a problem hiding this comment.
This works for this block, but I don't think it will work for the for lookup below.
Maybe do an "if starts with ~, replace with home dir" approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue: #80
I also increased the
vscode-extensionpatch version from0.14.0to0.14.1. Ideally I'd do that in a separate PR, but as this repo seems relatively quiet, I don't think there's gonna be any conflict/problem...