MONGOID-5863 #last overrides #skip
#5975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was being set even if n==0, which overrode any previously declared skip.
|
Assigned |
jamis
requested review from
alcaeus
and removed request for
comandeo-mongo and
tom-selander
alcaeus
approved these changes
Apr 16, 2025
let's take this opportunity to simplify the GHA test workflow
|
By the way, I still haven't upgraded from Mongoid 7 due to concern over bugs like this (as well as performance issues). I am thinking to try upgrading soon, I will likely find more things. |
|
Regression found, as expected: https://jira.mongodb.org/browse/MONGOID-5865 |
| it "returns the nth from last element" do | ||
| expect(context.skip(1).last).to eq(depeche_mode) | ||
| end | ||
| end |
There was a problem hiding this comment.
The method has sort(inverse_sorting) and then later v.to_a.reverse, which ensure the ordering in the case that multiple docs are returned.
Is this covered by tests? i.e. ensuring correct document ordering the result for multiple docs?
- combining
skip(n)withlimit(m)(where n, m > 1) last(n)(where n > 1)
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Jun 23, 2025
* remove redundant skip() This was being set even if n==0, which overrode any previously declared skip. * GHA is retiring ubuntu-20.04 let's take this opportunity to simplify the GHA test workflow * try and fix syntax error * try again
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Jun 23, 2025
* remove redundant skip() This was being set even if n==0, which overrode any previously declared skip. * GHA is retiring ubuntu-20.04 let's take this opportunity to simplify the GHA test workflow * try and fix syntax error * try again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to Mongoid 8.1,
Model.skip(1).lastwould return the next-to-last document. A refactoring in 8.1 resulted in this breaking, due to an extraneous call to#skipthat would override any other invocation of#skip.Summary
Fixes
Model.skip(1).lastso it again returns the next-to-last document, instead of just the last document.