Skip to content

MONGOID-5863 last overrides skip (backport to 8.1) #5997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025

Conversation

jamis
Copy link
Contributor

@jamis jamis commented Jun 23, 2025

This is a backport of #5975, fixing a regression that caused calls to #last to override any #skip that had been specified.

* remove redundant skip()

This was being set even if n==0, which overrode any previously
declared skip.

* GHA is retiring ubuntu-20.04

let's take this opportunity to simplify the GHA test workflow

* try and fix syntax error

* try again
@jamis jamis requested a review from a team as a code owner June 23, 2025 14:40
@jamis jamis requested a review from comandeo-mongo June 23, 2025 14:40
@jamis jamis added the bug Fixes a bug, with no new features or broken compatibility label Jun 23, 2025
@jamis jamis changed the base branch from master to 8.1-stable June 23, 2025 14:40
@jamis jamis merged commit dd08aeb into mongodb:8.1-stable Jun 26, 2025
48 of 50 checks passed
@jamis jamis deleted the 5863-last-overrides-skip-8.1 branch June 26, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes a bug, with no new features or broken compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants