Skip to content

Output attempted address in strict mode #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions mocket/mode.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,28 @@ def is_allowed(self, location: str | tuple[str, int]) -> bool:
return host_allowed or location in self.STRICT_ALLOWED

@staticmethod
def raise_not_allowed() -> NoReturn:
def raise_not_allowed(
address: tuple[str, int] | None = None,
data: bytes | None = None,
) -> NoReturn:
current_entries = [
(location, "\n ".join(map(str, entries)))
for location, entries in Mocket._entries.items()
]
formatted_entries = "\n".join(
[f" {location}:\n {entries}" for location, entries in current_entries]
)
raise StrictMocketException(
"Mocket tried to use the real `socket` module while STRICT mode was active.\n"
f"Registered entries:\n{formatted_entries}"
msg = (
"Mocket tried to use the real `socket` module while STRICT mode was active."
)
if address:
host, port = address
msg += f"\nAttempted address: {host}:{port}"
if data:
from mocket.compat import decode_from_bytes

preview = decode_from_bytes(data).split("\r\n", 1)[0][:200]
msg += f"\nFirst request line: {preview}"

msg += f"\nRegistered entries:\n{formatted_entries}"
raise StrictMocketException(msg)
2 changes: 1 addition & 1 deletion mocket/socket.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def recv(self, buffersize: int, flags: int | None = None) -> bytes:

def true_sendall(self, data: bytes, *args: Any, **kwargs: Any) -> bytes:
if not MocketMode().is_allowed(self._address):
MocketMode.raise_not_allowed()
MocketMode.raise_not_allowed(self._address, data)

# try to get the response from recordings
if Mocket._record_storage:
Expand Down
2 changes: 2 additions & 0 deletions tests/test_mode.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ def test_strict_mode_error_message():
str(exc_info.value)
== """
Mocket tried to use the real `socket` module while STRICT mode was active.
Attempted address: httpbin.local:80
First request line: GET /ip HTTP/1.1
Registered entries:
('httpbin.local', 80):
Entry(method='GET', schema='http', location=('httpbin.local', 80), path='/user.agent', query='')
Expand Down