-
Notifications
You must be signed in to change notification settings - Fork 46
Output attempted address in strict mode #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output attempted address in strict mode #296
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## better-strict-mode #296 +/- ##
======================================================
+ Coverage 98.71% 98.72% +0.01%
======================================================
Files 22 22
Lines 1010 1019 +9
======================================================
+ Hits 997 1006 +9
Misses 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What if we allow redefining the |
ah interesting so like another mode besides |
I changed my mind, kept your code and just changed |
* Output attempted address in strict mode (#296) * Update test * Make it more HTTP-agnostic. --------- Co-authored-by: Wilhelm Klopp <wilhelmklopp@users.noreply.github.com>
@wilhelmklopp Here is the release with a better strict mode: |
@mindflayer very exciting, thanks! 🎉 |
This is another change on the back of #295 – I made this locally and it helped quite a bit as i was migrating from httpretty to mocket. This way you can see which url the test tried to access, but couldn't.
Was specifically quite helpful in figuring out the querystring issue. Example output:
Feel free to edit the code or make a separate PR if there's a better way to do this. I think the code works fine as-is for http mocking, but haven't tested with any kind of other socket.