Skip to content

Match querystring for multiple responses in httpretty plugin #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wilhelmklopp
Copy link
Contributor

I'm migrating a large codebase with lots of http mocking from httpretty to python-mocket and making heavy use of your httpretty plugin – many thanks for making this and for actively maintaining python-mocket! ❤️ It is much appreciated!

This PR makes sure match_querystring is passed along properly to ~Entrywhen multiple responses are registered using the httpretty plugin. match_querystring` is already passed along as expected when a single response is registered, but not currently when multiple responses are registered.

This change makes a bunch of my tests pass, that otherwise would not

Copy link

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (13b2b94) to head (712af58).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          22       22           
  Lines        1010     1010           
=======================================
  Hits          997      997           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mindflayer mindflayer merged commit 496212a into mindflayer:main Jun 10, 2025
11 checks passed
@mindflayer
Copy link
Owner

@wilhelmklopp here you have a new release with your change:
https://pypi.org/project/mocket/3.13.8/

@wilhelmklopp wilhelmklopp deleted the match-qs-for-multiple-responses branch June 10, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants