Pass PBRMaterial name to SimpleMaterial during conversion #2470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the name of PBRMaterial is lost when calling to_simple() which causes issues when exporting meshes with named materials in obj format.
mikedh
added a commit
that referenced
this pull request
Oct 10, 2025
|
Great thanks for the fix! I also added the fix in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mikedh!
Currently the name of PBRMaterial is lost when calling to_simple() which causes issues when exporting meshes with named materials in obj format. More specifically, the baseColorTexture will always be saved as an image with name
material_0.png, and I couldn't find any workaround to override this name; this means if saving two such meshes in the same directory, only the last texture image would be available. I provided the simple fix to pass the name, but please let me know if there is an alternative.Thanks for the amazing library!