Skip to content

Release: Unit Hints #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Release: Unit Hints #2468

wants to merge 11 commits into from

Conversation

mikedh
Copy link
Owner

@mikedh mikedh commented Sep 26, 2025 •
edited
Loading

  • Be more flexible in getting unit hints from file names since it was a little silly that 20mm-xyz-cube did not resolve as mm.
  • Apply actions guidance updating to use the macos-15-intel image.
  • test and fix trimesh.scene.lighting.autolight crashing on empty scenes by checking scene.bounds is None
  • release Pass PBRMaterial name to SimpleMaterial during conversion #2470
  • add a note about whether or not we should apply the fix from Material fixes for trimesh.util.concatenate() #2457 to PBRMaterial.to_simple using the same conversion function for the linear baseColorFactor to RGB, but don't actually apply the change as it seems likely to be a source of user confusion.
  • add a Path2D.convex_hull to match every other geometry method.
  • update test_scene.py to pytest style

mikedh and others added 11 commits September 26, 2025 15:41
@mikedh
be more flexible with units in the filename
e030488
@mikedh
fix comment typos
cb9222b
@mikedh
apply github actions macos intel updated guidance
d979e49
@mikedh
don't crash trying to light empty scenes
193e82c
@mikedh
update scene tests to modern pytest style
f1d9d22
@AndreeaDogaru
Pass PBRMaterial name to SimpleMaterial during conversion
d96f279 
Currently the name of PBRMaterial is lost when calling to_simple() which causes issues when exporting meshes with named materials in obj format.
@mikedh
Pass PBRMaterial name to SimpleMaterial during conversion (#2470)
7726903 
Hi @mikedh!

Currently the name of PBRMaterial is lost when calling to_simple() which
causes issues when exporting meshes with named materials in obj format.
More specifically, the baseColorTexture will always be saved as an image
with name ```material_0.png```, and I couldn't find any workaround to
override this name; this means if saving two such meshes in the same
directory, only the last texture image would be available. I provided
the simple fix to pass the name, but please let me know if there is an
alternative.

Thanks for the amazing library!
@mikedh
add test for #2470 and fix from #2457
4478936
@mikedh
add a convex hull for path2d
b229684
@mikedh
fix diffuse but revert to avoid confusion
ba2366c
@mikedh
check for empty hull candidates
b22fa48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikedh @AndreeaDogaru