listeners for notebook replace input element #247684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justschen
approved these changes
Apr 28, 2025
2 tasks
mustard-mh
pushed a commit
to gitpod-io/openvscode-server
that referenced
this pull request
Apr 30, 2025
* add replace listeners -- wip * guess what? typescript isn't an HDL. order matters smh
NikolaRHristov
pushed a commit
to CodeEditorLand/Editor
that referenced
this pull request
Apr 30, 2025
* add replace listeners -- wip * guess what? typescript isn't an HDL. order matters smh
mustard-mh
pushed a commit
to gitpod-io/openvscode-server
that referenced
this pull request
May 7, 2025
* add replace listeners -- wip * guess what? typescript isn't an HDL. order matters smh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #247635
Unblocks: #247459
An oversight during initial implementation. Made the assumption that there was already a local history for the replace input box, allowing you to navigate through history. There never was, so any time you typed in the replace box, it would never get added to the history set, even the local set that wasn't persistent.
Missed it in the initial test because there was history always coming from the standard editor find widget once the storage was set up which was always navigable. Had to set both settings to never which would effectively flush the storage, and reveal the issue in notebooks.
Anyways this just adds the listeners.