Skip to content

Test: Find/Replace history persistence in Notebook #247459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
Yoyokrazy opened this issue Apr 25, 2025 · 2 comments
Closed
2 tasks done

Test: Find/Replace history persistence in Notebook #247459

Yoyokrazy opened this issue Apr 25, 2025 · 2 comments

Comments

@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Apr 25, 2025

Refs: #238923

Complexity: 2

author: @Yoyokrazy

Create Issue


Summary

The notebook find widget now supports history persistence identically to the editor find widget. This is controlled with the editor setting, so the feature can be controlled with editor.find.history and editor.find.replaceHistory for the find and replace fields respectively

Steps to Test:

  • Open a notebook editor + the find widget
  • With history set to workspace, execute multiple queries
  • Reload
  • Ensure history is still behaving as expected
  • Repeat with history set to never
  • Ensure there is no history after a reload

Thanks for testing!

@Yoyokrazy
Copy link
Contributor Author

Yoyokrazy commented Apr 28, 2025

Blocked atm ✋

Listener issues with specifically notebook find widget replace input box. Previously appeared to work because history was being carried from the editor find widget, as a false positive.

✅ Fixed with: #247684 -- will be good to test/verify in the next build insiders build.

@mrleemurray
Copy link
Contributor

mrleemurray commented Apr 29, 2025

Tested on macOS: confirmed that expected behaviour was observed:

  • history set to workspace, maintained both find & replace histories
  • history set to never, no find or replace histories

@mrleemurray mrleemurray removed their assignment Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants