.Net: Obsolete custom mappers #11366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step of microsoft#11129
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
westey-m
approved these changes
Apr 4, 2025
4 tasks
roji
added a commit
that referenced
this pull request
Apr 14, 2025
We obsoleted custom mappers in #11366. However, while work on IEmbeddingGenerator integration (#10492),I realized that for proper embedding generation, we need to generate all embeddings for an UpsertAsync batch in one call, rather than one-by-one (which would be many roundtrips). This means that mapping can't happen record by record, but must work on a batch, breaking the current design of IVectorStoreRecordMapper. As IVectorStoreRecordMapper is getting in the way, and custom mappers is a feature we don't think many people are using, this PR removes support for it (making it obsolete-with-error).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This obsoletes the public-facing parts of custom mappers, and suppresses internal warnings around them. After we release the next preview, we'll be removing these.
First step of #11129