.Net: Remove custom mappers #11530
Merged
.Net: Remove custom mappers #11530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
roji
force-pushed
the
ReallyRemoveCustomMappers
branch
from
dcaa9f0 to
aadedc9
Compare
roji
force-pushed
the
ReallyRemoveCustomMappers
branch
3 times, most recently
from
588eb83 to
a359fcc
Compare
roji
force-pushed
the
ReallyRemoveCustomMappers
branch
from
a359fcc to
e3110ec
Compare
roji
force-pushed
the
ReallyRemoveCustomMappers
branch
from
e3110ec to
a8e0875
Compare
westey-m
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We obsoleted custom mappers in #11366. However, while work on IEmbeddingGenerator integration (#10492),I realized that for proper embedding generation, we need to generate all embeddings for an UpsertAsync batch in one call, rather than one-by-one (which would be many roundtrips). This means that mapping can't happen record by record, but must work on a batch, breaking the current design of IVectorStoreRecordMapper.
As IVectorStoreRecordMapper is getting in the way, and custom mappers is a feature we don't think many people are using, this PR removes support for it (making it obsolete-with-error).