[rush] rush-sdk try to load from global folder before install-and-run rush #3878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengcyber
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
patmill
as code owners
chengcyber
changed the title
iclanton
reviewed
Jan 10, 2023
common/changes/@microsoft/rush/feat-rush-sdk-load-from-global-folder_2023-01-08-12-28.json
Outdated
Show resolved
Hide resolved
chengcyber
force-pushed
the
feat-rush-sdk-load-from-global-folder
branch
from
51077b4 to
3884bb4
Compare
chengcyber
force-pushed
the
feat-rush-sdk-load-from-global-folder
branch
from
88c8e3b to
ef31e73
Compare
chengcyber
force-pushed
the
feat-rush-sdk-load-from-global-folder
branch
from
1eb2be2 to
64a0288
Compare
|
This MR has been a while. I recalled it and updated the code! Use |
iclanton
reviewed
Jun 19, 2024
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
|
Hi @iclanton , I pushed code modifications as your suggestions. Could you kindly take another look? Thx! |
iclanton
approved these changes
Jun 22, 2024
|
For the merge conflict, I merged the latest main branch and fixed it yesterday. However, there is a merge conflicts with main's repo-state.json today... |
…-load-from-global-folder # Conflicts: # common/config/subspaces/build-tests-subspace/repo-state.json
|
🚀 Finally released with Rush 5.129.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR add a feature to
rush-sdk.Details
Before invoking install-and-run rush, try to load rush-lib from rush global folder for a better reuse of installed rush-lib.
How it was tested
Tested locally
Impacted documentation
Nope