[rush-sdk] Use rush-lib from parent process #3972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
iclanton,
octogonz,
apostolisms and
D4N14L
as code owners
|
Complementary to #3878 ; this code path should be tried before the code path added there (since its a quick read of a variable), but both should be tried before falling back to invoking |
dmichon-msft
force-pushed
the
rush-sdk-env
branch
from
8332156 to
dacf936
Compare
octogonz
reviewed
Feb 17, 2023
octogonz
reviewed
Feb 17, 2023
octogonz
reviewed
Feb 17, 2023
common/changes/@microsoft/rush/rush-sdk-env_2023-02-10-23-15.json
Outdated
Show resolved
Hide resolved
octogonz
reviewed
Feb 17, 2023
It also should probably be added to Rush's EnvironmentVariables.ts, and also the https://rushjs.io/pages/configs/environment_vars/ page. |
octogonz
approved these changes
Feb 17, 2023
dmichon-msft
commented
Feb 17, 2023
|
@dmichon-msft please see the issue recently reported. [[rush] Installing @latest rush with a downgraded rushVersion specified in rush.json · Issue #3979 · microsoft/rushstack (github.com)](#3979) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds another code path to
@rushstack/rush-sdkwith higher precedence thaninstall-run-rush.jsthat will try to use a version of@microsoft/rush-libprovided via environment variableRUSH_LIB_PATH. This environment variable will get set by@microsoft/rush-libwhen loaded and propagated to child processes.Details
When the
Rushmodule in@microsoft/rush-libloads, it sets theRUSH_LIB_PATHenvironment variable onprocess.env, so that it will propagate to child processes. When initializing,@rushtack/rush-sdkwill check this environment variable before falling back to invokinginstall-run-rush.js.How it was tested
Added unit tests to
@rushstack/rush-sdkto test primary loader code paths.Validated that
process.env.RUSH_LIB_PATHwas set when the unit tests were invoked via the new build of Rush (and needed to update the unit tests to clear the value).Impacted documentation
Readme for
@rushstack/rush-sdk. Comments on public API ofEnvironmentVariables.tsin@microsoft/rush-lib.