Integrate RN Nightly Build 0.79.0-nightly-20250220-41b597c73 #14662
Conversation
…riya13/react-native-windows into user/anuverma/integrate_feb
…riya13/react-native-windows into user/anuverma/integrate_feb
This reverts commit 8c0b9a8.
anupriya13
added
Workstream: Releases and Integrations
There was a problem hiding this comment.
why do we have this here? what lines are we changing?
There was a problem hiding this comment.
Looks like there isn't a follow up issue attached, but the upstream HostPlatformTouch.h files are identical - will remove.
There was a problem hiding this comment.
The thing is one file is including this file.. and was not able to find it. That's why added it here.
There was a problem hiding this comment.
Deleted the file from here and added the path in vcxproj CIIncludes
There was a problem hiding this comment.
Throwing build errors again, reverting
There was a problem hiding this comment.
why do we have this here? what lines are we changing? why do we have this AND the HostPlatformViewEventEmitter under Microsoft.ReactNative/Fabric/platform/...? @acoates-ms Does this look right? Or will we effective lose the Windows changes to this type depending on which file is imported?
There was a problem hiding this comment.
This file is in another file #include.. and was not able to find it. That's why added it here.
There was a problem hiding this comment.
Deleted the file from here and added the path in vcxproj CIIncludes
There was a problem hiding this comment.
Throwing build errors again, reverting
There was a problem hiding this comment.
why do we have this here? what lines are we changing?
There was a problem hiding this comment.
Same as above. This file is in another file #include.. and was not able to find it. That's why added it here.
There was a problem hiding this comment.
Deleted the file from here and added the path in vcxproj CIIncludes
There was a problem hiding this comment.
Throwing build errors again, reverting
| #include <jsireact/JSIExecutor.h> | ||
| #include <react/renderer/runtimescheduler/RuntimeScheduler.h> | ||
| #include <react/runtime/BufferedRuntimeExecutor.h> | ||
| #include <jsitooling/react/runtime/JSRuntimeFactory.h> // Windows |
There was a problem hiding this comment.
This override shouldn't be necessary if the project now has the jsitooling folder in its include path.
There was a problem hiding this comment.
We tested it but it was failing even with the jsitooling added in vcxproj
There was a problem hiding this comment.
The CI Include was missing for this file in vcxproj, fixed it and removed override.
There was a problem hiding this comment.
Throwing build errors again, reverting
anupriya13
force-pushed
the
user/anuverma/integrate_feb
branch
from
54a5bdd to
6ab0bc3
Compare
Description
Integration 0.79.0-nightly-20250220-41b597c73
Commit Range
facebook/react-native@fb8a6a5...41b597c
Relevant Commits:
Relevant Issues:
Changelog
Should this change be included in the release notes: No
Microsoft Reviewers: Open in CodeFlow