Copy React/Renderer/Components/View FIles to make build succeed

[anupriya13]

Problem Description

These files were added to /vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/components directory
#14664

1. vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/components/view/HostPlatformTouch.h
2. vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/components/view/HostPlatformViewEmitter.h
3. vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/components/view/HostPlatformViewProps.h
4. vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/graphics/HostPlatformColor.h

Link to the integration where the error originated

#14664

Link to commit

facebook/react-native@f2c78af

Forked files

No response

Upstream PR

No response

Build Configuration

None

[jonthysell]

The problem here is that the files we added are the kind of example HostPlatform*.h header examples, where we simply pass through the types with using HostPlatformClassName = BaseClassName. Since all the upstream ReactCommon code only uses those base class members anyway, the code compiles.

However, some, like HostPlatformViewEventEmitter, we do actually create our own child class with Windows-specific members, we just do it up in Micrsoft.ReactNative/Fabric/platform/react/renderer/components. It's this file that we use when we build our code.

Right now I think the only reason why what we're doing works relies on how C++ classes inherit and extend each other - so the upstream code is effectively getting an implicit cast of the base class and our code uses the correct full class.

Either way, this setup with two headers with the same name, both creating different versions of the same class, and being used simultaneously by different parts of the code feels like we're setting ourselves up for shenanigans if and when compiler optimizations misalign the two versions and we end up with weird behavior / crashes.