Skip to content

dynamic_cast throws error #14673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
anupriya13 opened this issue May 15, 2025 · 1 comment · Fixed by #14662
Open

dynamic_cast throws error #14673

anupriya13 opened this issue May 15, 2025 · 1 comment · Fixed by #14662
Assignees
@anupriya13
Labels
Area: ScrollView Integration Follow-up Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Milestone
Next

Comments

@anupriya13
Copy link
Contributor

anupriya13 commented May 15, 2025 •
edited
Loading

Problem Description

dynamic_cast throws error in CullingContext.cpp and sliceChildShadowNodeViewPairs.cpp.
Changes dynamic_cast to static_cast

Link to the integration where the error originated

#14662

Link to commit

facebook/react-native#49307

Forked files

No response

Upstream PR

No response

Build Configuration

None
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 15, 2025
@anupriya13 anupriya13 linked a pull request May 17, 2025 that will close this issue
Integrate RN Nightly Build 0.79.0-nightly-20250220-41b597c73 #14662
Merged
@anupriya13 anupriya13 mentioned this issue May 17, 2025
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 20, 2025
@jonthysell jonthysell reopened this May 21, 2025
@jonthysell jonthysell added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 21, 2025
@jonthysell jonthysell added New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Area: ScrollView and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels May 22, 2025
@jonthysell
Copy link
Contributor

jonthysell commented May 22, 2025 •
edited
Loading

This looks like we may need to enable dynamic_casts (RTTI) at a project level (and take the binary size hit).

react-native-windows/vnext/PropertySheets/React.Cpp.props

Line 139 in 1e8e1a3

<RuntimeTypeInfo>false</RuntimeTypeInfo>

@jonthysell jonthysell added this to the Next milestone May 22, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anupriya13 anupriya13

Labels
Area: ScrollView Integration Follow-up Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
None yet
Milestone
Next
Development

Successfully merging a pull request may close this issue.

Integrate RN Nightly Build 0.79.0-nightly-20250220-41b597c73 anupriya13/react-native-windows
2 participants
@jonthysell @anupriya13