virt_mshv_vtl, SNP: Fix a todo in the intercept processing #1628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement what the TODO requests: * Add a comment to explain why halt messages are expected, * Check that the only exception intercept messages are for the VC traps, and document that. Tested by booting various SEV-SNP VMs.
smalis-msft
reviewed
Jul 2, 2025
| // Ignore. | ||
| // | ||
| // TODO SNP: Figure out why we are getting these. | ||
| HvMessageType::HvMessageTypeX64Halt => { |
There was a problem hiding this comment.
Where is it being processed?
There was a problem hiding this comment.
- Above in the
matchblock, there is an arm for the HLT exit, - In the same block, when processing the MSR exit,
read_msr_snpis called which checks forhvdef::HV_X64_MSR_GUEST_IDLE.
The intercept message from the hypervisor can't offer a better/more trustworthy data than that one (generated by the hardware). Both cases are handled with the VP "parked" in the state allowing for interrupts being delivered. That all made the impression all that's required to be done must be already done.
There was a problem hiding this comment.
Maybe we should assert or check/warn that the SevExitCode is what we'd expect here?
smalis-msft
reviewed
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement what the TODO requests:
Tested by booting various SEV-SNP VMs.