Upgrades release/client/2.23 pipeline deployment jobs to be 1ES compliant #24118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read THIS FIRST
This change is being ported from main: #24026
Below is a repeat of the description from the above linked PR. The goal here is to ensure that if we decide to rerelease this fluid version that our deployment pipeline is 1ES compliant.
Description
1es pipelines have warnings requiring that all deployment jobs transition to release jobs (see Custom Release Job | 1ES On EngHub).
The
include-publish-npm-package-deployment.yml
is a template included in many pipelines, including the build client pipeline. This template includes a deployment job that needed to be upgraded to a 1ES compliant.To that effort, a few changes have been made to pipelines:
include-publish-npm-package-deployment.yml
. This was necessary to install build tools properly.include-publish-npm-package-deployment.yml
.include-publish-npm-package-deployment.yml
using the downloaded FF repo was removed and replaced with a bash script that installs the build tools from the tarball artifact from the 'Build - Build Tools' pipeline.include-publish-npm-package-deployment.yml
which specifies variables necessary to make is a 1ES deployment job and this also includes a dynamic isProduction variable based on the 'testBuild' parameter frominclude-vars.yml
pipeline templateinclude-publish-npm-package-deployment.yml
uses the newtemplateContext
section to download the pipeline artifact from 'Build - Build tools' using theinputs
parameter rather than a explicitly defined task. This also applies to downloading thepack
artifact from the build stage of the pipelineReviewer Guidance
1ES Release Job Requirements: (see links above for more details)