Skip to content

build(client): Fix configs preventing incremental build #22897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
aa7cf31
down to 8 tasks
tylerbutler Oct 24, 2024
c75419d
Merge branch 'main' into incremental-build
tylerbutler Oct 29, 2024
9ebd7b8
Merge branch 'main' into incremental-build
tylerbutler Nov 18, 2024
10a4e39
Merge branch 'main' into incremental-build
tylerbutler Nov 23, 2024
2e27b73
Merge branch 'main' into incremental-build
tylerbutler Nov 23, 2024
927c2e0
revert allowJs changes in property-properties
tylerbutler Nov 23, 2024
2206557
rm allowJs in ai-collab
tylerbutler Nov 23, 2024
2108735
unused tasks in data-object-base
tylerbutler Nov 23, 2024
d4b50d0
Merge branch 'incremental-build' of https://github.com/tylerbutler/Fl…
tylerbutler Nov 23, 2024
c256418
tsc task fixes
tylerbutler Nov 23, 2024
6228456
link build-tools
tylerbutler Nov 23, 2024
1fd3968
format
tylerbutler Nov 23, 2024
113e1f0
Add FlubCheckBuildVersionTask and LeafWithGlobInputOutputDoneFileTask
tylerbutler Nov 23, 2024
e0a4838
DeclarativeTask inherits from LeafWithGlobInputOutputDoneFileTask
tylerbutler Nov 23, 2024
9b2d680
microdiff
tylerbutler Nov 23, 2024
6f47800
homegrown object diff
tylerbutler Nov 23, 2024
33db651
revert microdiff
tylerbutler Nov 23, 2024
b79f385
updates
tylerbutler Nov 23, 2024
467d273
comments
tylerbutler Nov 23, 2024
056d577
revert linking
tylerbutler Nov 23, 2024
e559315
revert build-tools fixes
tylerbutler Nov 23, 2024
4724d55
Update fluidBuild.config.cjs
tylerbutler Nov 26, 2024
2203bd4
Merge branch 'main' into incremental-build
tylerbutler Nov 26, 2024
b64edb1
Update examples/apps/ai-collab/tsconfig.json
tylerbutler Nov 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/apps/ai-collab/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"extends": "../../../common/build/build-common/tsconfig.node16.json",
"compilerOptions": {
"lib": ["dom", "dom.iterable", "esnext"],
"allowJs": true,
// "allowJs": true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required for this project?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. @seanimam was this put there deliberately?

"skipLibCheck": true,
"strict": true,
"noEmit": true,
Expand Down
25 changes: 25 additions & 0 deletions fluidBuild.config.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,35 @@ module.exports = {

multiCommandExecutables: ["oclif", "syncpack"],
declarativeTasks: {
"flub check buildVersion": {
inputGlobs: [
"package.json",

// release group packages; while ** is supported, it is very slow, so these entries capture all the levels we
// have packages at today. Once we can upgrade to a later version of
// globby things might be faster.
"{azure,examples,experimental,packages}/*/*/package.json",
"{azure,examples,experimental,packages}/*/*/*/package.json",
"{azure,examples,experimental,packages}/*/*/*/*/package.json",
"tools/markdown-magic/package.json",
],
outputGlobs: ["package.json"],
gitignore: ["input", "output"],
},
"jssm-viz": {
inputGlobs: ["src/**/*.fsl"],
outputGlobs: ["src/**/*.fsl.svg"],
},
"markdown-magic": {
inputGlobs: [],
outputGlobs: [
"{azure,examples,experimental,packages}/*/*/*.md",
"{azure,examples,experimental,packages}/*/*/*/*.md",
"{azure,examples,experimental,packages}/*/*/*/*/*.md",
"tools/markdown-magic/**/*.md",
],
gitignore: ["input", "output"],
},
"oclif manifest": {
inputGlobs: ["package.json", "src/**"],
outputGlobs: ["oclif.manifest.json"],
Expand Down
2 changes: 1 addition & 1 deletion packages/framework/data-object-base/.eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
module.exports = {
extends: [require.resolve("@fluidframework/eslint-config-fluid/strict"), "prettier"],
parserOptions: {
project: ["./tsconfig.json", "./src/test/tsconfig.json"],
project: ["./tsconfig.json"],
},
rules: {
"@typescript-eslint/strict-boolean-expressions": "off",
Expand Down
7 changes: 1 addition & 6 deletions packages/framework/data-object-base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@
"build:compile": "fluid-build . --task compile",
"build:docs": "api-extractor run --local",
"build:esnext": "tsc --project ./tsconfig.json",
"build:test": "npm run build:test:esm && npm run build:test:cjs",
"build:test:cjs": "fluid-tsc commonjs --project ./src/test/tsconfig.cjs.json",
"build:test:esm": "tsc --project ./src/test/tsconfig.json",
"check:are-the-types-wrong": "attw --pack .",
"check:biome": "biome check .",
"check:exports": "concurrently \"npm:check:exports:*\"",
Expand All @@ -57,9 +54,7 @@
"format:prettier": "prettier --write . --cache --ignore-path ../../../.prettierignore",
"lint": "fluid-build . --task lint",
"lint:fix": "fluid-build . --task eslint:fix --task format",
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist",
"typetests:gen": "flub generate typetests --dir . -v",
"typetests:prepare": "flub typetests --dir . --reset --previous --normalize"
"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist"
},
"dependencies": {
"@fluid-internal/client-utils": "workspace:~",
Expand Down
12 changes: 0 additions & 12 deletions packages/framework/data-object-base/src/test/tsconfig.cjs.json

This file was deleted.

15 changes: 0 additions & 15 deletions packages/framework/data-object-base/src/test/tsconfig.json

This file was deleted.

Loading