build(client): Fix configs preventing incremental build #22897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbutler
changed the title
github-actions
bot
added
area: dds: propertydds
base: main
…uidFramework into incremental-build
github-actions
bot
added
area: examples
tylerbutler
commented
Nov 23, 2024
| @@ -2,7 +2,7 @@ | |||
| "extends": "../../../common/build/build-common/tsconfig.node16.json", | |||
| "compilerOptions": { | |||
| "lib": ["dom", "dom.iterable", "esnext"], | |||
| "allowJs": true, | |||
| // "allowJs": true, | |||
There was a problem hiding this comment.
Is this required for this project?
There was a problem hiding this comment.
I don't think so. @seanimam was this put there deliberately?
tylerbutler
commented
Nov 23, 2024
github-actions
bot
added
area: build
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: e71e434 |
github-actions
bot
removed
dependencies
alexvy86
approved these changes
Nov 25, 2024
Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
tylerbutler
commented
Nov 26, 2024
|
I'm merging this including the ai-collab change because CI is clear, and there doesn't seem to be any other need for the setting in the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several problems causing builds to not be fully incremental.
flub check buildversionandmarkdown-magic."allowJs": truein its tsconfig. That setting causes problems with incremental builds (see improvement(fluid-build): Ignore some tsconfig fields when determining incremental build #23197 for more details). It's removed in this change but if it is truly needed then I'll add it back.