Skip to content

Conversation

zas
Copy link
Collaborator

@zas zas commented Apr 15, 2025

Suggested by @phw in #2633 (review)

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@zas
Copy link
Collaborator Author

zas commented Apr 15, 2025

@phw @rdswift Perhaps we should also rename it, do you have any ideas for a better name?

@phw
Copy link
Member

phw commented Apr 15, 2025

Perhaps we should also rename it, do you have any ideas for a better name?

Maybe KNOWN_VARIABLES? Because there is an endless amount of possible variable names, but this includes certain ones that are used internally by Picard and are generally known.

@zas
Copy link
Collaborator Author

zas commented Apr 15, 2025

Perhaps we should also rename it, do you have any ideas for a better name?

Maybe KNOWN_VARIABLES? Because there is an endless amount of possible variable names, but this includes certain ones that are used internally by Picard and are generally known.

Not sure about the name, I'll merge this PR, we can rename later.

@zas zas merged commit 1a684b0 into metabrainz:master Apr 15, 2025
51 checks passed
@zas zas deleted the move_extra_vars branch April 15, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants