Skip to content

Conversation

rdswift
Copy link
Collaborator

@rdswift rdswift commented Apr 14, 2025

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences: Adds the new %_albumartists_countries% and %_artists_countries% variables to the script editor autocomplete list.

Problem

Two new variables %_albumartists_countries% and %_artists_countries% were added in #2627 but were not added to the script editor autocomplete list at that time (because I forgot).

  • JIRA ticket (optional): PICARD-XXX

Solution

This change adds the new %_albumartists_countries% and %_artists_countries% variables to the script editor autocomplete list.

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

None.

@rdswift rdswift requested a review from phw April 14, 2025 18:02
@rdswift rdswift marked this pull request as draft April 14, 2025 18:11
@rdswift rdswift marked this pull request as ready for review April 14, 2025 18:33
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's merge this.

This is so easy to forget to update. Maybe we should move the EXTRA_VARIABLES constant to constants. Maybe inside tags.py, so we have all tags and variables in one place. @rdswift @zas what do you think?

@phw phw merged commit c062ade into metabrainz:master Apr 15, 2025
51 checks passed
zas added a commit to zas/picard that referenced this pull request Apr 15, 2025
@zas
Copy link
Collaborator

zas commented Apr 15, 2025

Thanks, let's merge this.

This is so easy to forget to update. Maybe we should move the EXTRA_VARIABLES constant to constants. Maybe inside tags.py, so we have all tags and variables in one place. @rdswift @zas what do you think?

Yes, I agree -> #2634

@rdswift rdswift deleted the artists_countries_autocomplete branch April 15, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants