-
Notifications
You must be signed in to change notification settings - Fork 401
MSC4210: Remove legacy mentions #4210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9d2c045
Remove legacy mentions
tulir cf6e0b3
Add another potential issue
tulir cf91dce
Add new room version to alternatives
tulir 0fa385a
Specify that including `m.mentions` in all events is still necessary
tulir 5af06f5
Add links to current spec
tulir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
# MSC4210: Remove legacy mentions | ||
Matrix v1.7 introduced intentional mentions, where events list users they | ||
tulir marked this conversation as resolved.
Show resolved
Hide resolved
|
||
mention explicitly, instead of the recipients inferring mentions from the raw | ||
message text. For backwards-compatibility reasons, messages without the new | ||
`m.mentions` field still use the old plaintext matching for mentions. | ||
|
||
Plaintext matching means it's very difficult for automated tools to tell which | ||
users are mentioned in a message. This means that it's easy to spam mentions by | ||
simply not using intentional mentions. | ||
|
||
If intentional mentions are mandatory, automated tools could easily ban users | ||
who send more than X mentions in a single message. There could even be a new | ||
push rule condition to allow checking the number of mentioned users and skip | ||
notifying entirely. | ||
|
||
## Proposal | ||
tulir marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Support for legacy mentions is dropped. Specifically, the following deprecated | ||
standard push rules are removed entirely: | ||
|
||
* `.m.rule.contains_display_name` | ||
* `.m.rule.contains_user_name` | ||
* `.m.rule.roomnotif` | ||
tulir marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Additionally, the `contains_display_name` push rule condition is deprecated. | ||
clokep marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Including an empty `m.mentions` key is still required for clients that are | ||
aware of intentional mentions, as omitting it would cause current clients to | ||
assume messages are not using intentional mentions. | ||
|
||
## Potential issues | ||
Users using old clients (which don't send intentional mentions) will no longer | ||
be able to mention users on up-to-date clients/servers. | ||
|
||
Users using old clients (which don't support the new push rule conditions) will | ||
also no longer be notified for mentions in case the client depends on the push | ||
rules served by the server. | ||
|
||
## Alternatives | ||
tulir marked this conversation as resolved.
Show resolved
Hide resolved
|
||
The removal could be done in a new room version, such as when switching to | ||
extensible events, as suggested by [MSC3952]. However, such a migration will | ||
likely take much longer than clients implementing intentional mentions. | ||
Additionally, the room upgrade UX is still an open issue, which means many | ||
rooms simply don't upgrade. Therefore, making a slightly breaking change to | ||
existing room versions seems like the better option. | ||
|
||
[MSC3952]: https://github.com/matrix-org/matrix-spec-proposals/pull/3952 | ||
|
||
## Security considerations | ||
This proposal doesn't add any features, so there are no new security | ||
considerations. | ||
|
||
## Unstable prefix | ||
Not applicable, this proposal only removes features. | ||
|
||
## Dependencies | ||
None. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.