Upgrade matrix-sdk-ui to Rust edition 2024 #5309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #5309 +/- ##
=======================================
Coverage 88.77% 88.78%
=======================================
Files 334 334
Lines 91317 91312 -5
Branches 91317 91312 -5
=======================================
Hits 81069 81069
+ Misses 6417 6409 -8
- Partials 3831 3834 +3 ☔ View full report in Codecov by Sentry. |
stefanceriu
reviewed
Jun 30, 2025
| edition = "2021" | ||
| edition = "2024" |
crates/matrix-sdk-ui/src/room_list_service/filters/fuzzy_match_room_name.rs
Show resolved
Hide resolved
| } else { | ||
| false | ||
| } | ||
| if let Some(edit) = best_edit { edit_item(event, edit) } else { false } |
There was a problem hiding this comment.
Ending a function in if let feels super strange to me, I think I liked the previous version better.
There was a problem hiding this comment.
It's the same, but formatted differently, right?
Comment on lines
+147
to
+148
| assert!( | ||
| event |
There was a problem hiding this comment.
Got mixed feelings about this one too.
stefanceriu
requested review from
a team and
Hywan
and removed request for
a team
Hywan
reviewed
Jun 30, 2025
crates/matrix-sdk-ui/src/room_list_service/filters/fuzzy_match_room_name.rs
Show resolved
Hide resolved
Automated with `cargo fix --edition -p matrix-sdk-ui`, reverting unnecessary changes.
jplatte
force-pushed
the
jplatte/ui-rust2024
branch
from
d7e0d85 to
caa71fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made sure that the two remaining PRs that blocked the large rustfmt PR (#5225, #5258) do not touch the UI crate, so this is not going to result in conflicts there.
There were a few more
+ use<_>clauses added in private interfaces, but they weren't necessary for compilation to succeed, so I omitted them. I doubt they will become required for anything later, but if they do, it's gonna be the same sort of situation as newly-added-> impl Traitreturn types, where surely nobody thinks to add+ use<>, and the compiler is hopefully going to suggest doing that where helpful.Signed-off-by: Jonas Platte