Small matrix-sdk-ui refactors #5372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in private methods.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #5372 +/- ##
==========================================
- Coverage 88.77% 88.76% -0.01%
==========================================
Files 334 334
Lines 91086 91082 -4
Branches 91086 91082 -4
==========================================
- Hits 80860 80849 -11
- Misses 6387 6394 +7
Partials 3839 3839 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Jul 9, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling @Hywan's feedback from #5309 in a separate PR. Will rebase the other PR afterwards.
Signed-off-by: Jonas Platte