feat: setup connection to notion db #21
Conversation
WalkthroughA new GitHub Actions workflow named Changes
Sequence Diagram(s)sequenceDiagram
participant Trigger as GitHub Event
participant Runner as GitHub Actions Runner
participant NotionAction as Notion Sync Action
participant NotionDB as Notion Database
Note over Trigger, Runner: Trigger can be manual dispatch or issue events
Trigger->>Runner: Initiate workflow (notion-sync.yaml)
Runner->>NotionAction: Run notion_job on ubuntu-latest
NotionAction->>NotionDB: Send issue data using secrets (GH_ISSUES_NOTION_TOKEN, GH_ISSUES_DB_ID)
NotionDB-->>NotionAction: Confirm update
NotionAction-->>Runner: Return status
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/notion-sync.yaml (2)
3-19: Trigger Configuration Verification & Readability Improvement
The workflow is triggered by bothworkflow_dispatchand a comprehensive list of issue events which is great for covering various lifecycle changes. The inline array notation for the issue types is valid YAML; however, switching to a block list might enhance readability and ease future maintenance. For example:- types: - [ - opened, - edited, - labeled, - unlabeled, - assigned, - unassigned, - milestoned, - demilestoned, - reopened, - closed, - ] + types: + - opened + - edited + - labeled + - unlabeled + - assigned + - unassigned + - milestoned + - demilestoned + - reopened + - closedConsider this change for improved maintainability.
20-29: Job and Action Setup Verification
The job "notion_job" is properly configured to run on the latest Ubuntu runner, and it clearly outlines the step to add GitHub issues to Notion using thetryfabric/notion-github-action@v1action. Please ensure that the repository secrets (GH_ISSUES_NOTION_TOKENandGH_ISSUES_DB_ID) are correctly set. Additionally, while using@v1is acceptable, consider pinning to a specific commit hash or release version for enhanced reproducibility and security. For instance:- uses: tryfabric/notion-github-action@v1 + uses: tryfabric/notion-github-action@v1.2.3 # Replace with the exact commit hash or version if availableThis optional refinement will help prevent unexpected changes from upstream updates.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/notion-sync.yaml(1 hunks)
🔇 Additional comments (1)
.github/workflows/notion-sync.yaml (1)
1-2: Workflow Name Clarity
The workflow name "Notion Sync" is clear and descriptive, aligning well with the PR objective of linking GitHub issues with Notion.
| issues: | ||
| types: |
There was a problem hiding this comment.
No, the gha action code is just focused on issues and specifically ignores issues that are PRs (see this line).
🤖 I have created a release *beep* *boop* --- ## [0.4.0](v0.3.0...v0.4.0) (2025-04-16) ### Features * setup connection to notion db ([#21](#21)) ([857df50](857df50)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
what
references
closes #INT-52, closes the issue INT-52Summary by CodeRabbit